22.10.2015 02:15, Richard Henderson wrote: > On 10/19/2015 04:08 AM, Paolo Bonzini wrote: >> I am not sure why the compiler does not catch it. There is no >> semantic change since gen_excp returns EXIT_NORETURN, but the >> old code is wrong. >> >> Reported by Coverity. >> >> Signed-off-by: Paolo Bonzini<pbonz...@redhat.com> >> --- >> target-alpha/translate.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Richard Henderson <r...@twiddle.net> > > I assume this will go in via trivial.
Richard, after your patch 522a0d4e3c0d397ffb45ec400d8cbd426dad9d17 "target-*: Advance pc after recognizing a breakpoint", this code needs another review I think, as you modified the subsequent line ;) Please take a look. Thanks, /mjt
