On Tue, Oct 13, 2015 at 07:10:33PM +0200, Lluís Vilanova wrote: > diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py > index 9b39430..4bdb48f 100644 > --- a/scripts/tracetool/format/h.py > +++ b/scripts/tracetool/format/h.py > @@ -6,7 +6,7 @@ trace/generated-tracers.h > """ > > __author__ = "Lluís Vilanova <vilan...@ac.upc.edu>" > -__copyright__ = "Copyright 2012-2014, Lluís Vilanova <vilan...@ac.upc.edu>" > +__copyright__ = "Copyright 2012-2015, Lluís Vilanova <vilan...@ac.upc.edu>" > __license__ = "GPL version 2 or (at your option) any later version" > > __maintainer__ = "Stefan Hajnoczi" > @@ -23,6 +23,8 @@ def generate(events, backend): > '#define TRACE__GENERATED_TRACERS_H', > '', > '#include "qemu-common.h"', > + '', > + 'typedef struct CPUState CPUState;',
Here... > diff --git a/scripts/tracetool/format/ust_events_c.py > b/scripts/tracetool/format/ust_events_c.py > index bc97093..92064f0 100644 > --- a/scripts/tracetool/format/ust_events_c.py > +++ b/scripts/tracetool/format/ust_events_c.py > @@ -6,7 +6,7 @@ trace/generated-ust.c > """ > > __author__ = "Mohamad Gebai <mohamad.ge...@polymtl.ca>" > -__copyright__ = "Copyright 2012, Mohamad Gebai <mohamad.ge...@polymtl.ca>" > +__copyright__ = "Copyright 2012, 2015, Mohamad Gebai > <mohamad.ge...@polymtl.ca>" > __license__ = "GPL version 2 or (at your option) any later version" > > __maintainer__ = "Stefan Hajnoczi" > @@ -30,4 +30,6 @@ def generate(events, backend): > ' */', > '#pragma GCC diagnostic ignored "-Wredundant-decls"', > '', > + 'typedef struct CPUState CPUState;', > + '', > '#include "generated-ust-provider.h"') ...and here is okay but please generate a comment so it's clear why this needs to be defined.