* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 12 October 2015 at 13:31, Daniel P. Berrange <berra...@redhat.com> wrote: > > On Mon, Oct 12, 2015 at 02:24:36PM +0200, Marc-André Lureau wrote: > >> What about just using the macro, but not bumping glib requirement? > > > > It would be desirable - I think someone explored using the GLIB_VERSION > > macros before, without bumping version. I can't remember what the problem > > was that made them abandon that though - maybe someone else recalls... > > I think that was David Gilbert, and I vaguely recall there being > bad interactions with our glib-compat.h header.
My notes and memory are both somewhat fuzzy on it. I think that the GLIB_VERSION_MIN/MAX macros only went in in 2.32 but then once you have them they offer a range allowing you to state you need a minimum of 2.26; so if we bump the minimum to 2.26 then becareful to check it still works at that. The interaction of stuff that includes glib.h and others that include glib-compat.h was messy; I was working on the assumption that stuff that included glib-compat.h knew it was using newer things and didn't expect a warning; the problem that Peter pointed out was that glib-compat gets included by qemu-common so actually the warnings get disabled in loads of places. Dave > > -- PMM -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
