On 10/08/2015 08:08 AM, Daniel P. Berrange wrote: > This patch series is a combination of my own previous patch to > add support for object properties against classes: > > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg05953.html > > And Pavel Fedin's patch to use a hash table instead of list > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg01455.html > > I pulled Pavel's patch in to my series, since both our patches > touch the same code and thus generate nasty merge conflicts. > > In resolving these conflicts I decided we needed a new helper > method object_property_foreach to deal with iteration over > properties, hence we now have a short series of patches. > > I made a few changes to Pavel's patch but the guts of it are > still his work, so I left him as GIT author, but removed his > Signed-off-by, since that would not apply to my own additions
Actually, I think what is typically done in that case is leaving both Signed-off-by lines (you both have contributions to the final product); often with two-stage commit messages: original comments.... Signed-off-by: person A additional changes... Signed-off-by: person B At any rate, Pavel should have an S-o-B line if he remains git author, regardless of who else also has a S-o-B line. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
