On Thu, Oct 08, 2015 at 06:27:39PM +0300, Pavel Fedin wrote: > Hi! > > Just got test report from my colleague, he forgot to specify > --target-list=aarch64-softmmu to configure and tried to build everything. > Looks like there are more property iterations done by hand in PowerPC code: > --- cut --- > In file included from /home/igor/qemu/include/qom/object.h:20:0, > from /home/igor/qemu/include/hw/ppc/spapr_drc.h:15, > from /home/igor/qemu/hw/ppc/spapr_drc.c:13: > /home/igor/qemu/hw/ppc/spapr_drc.c: In function ‘spapr_drc_populate_dt’: > /home/igor/qemu/include/qemu/queue.h:419:29: error: request for member > ‘tqh_first’ in something not a structure or union > for ((var) = ((head)->tqh_first); \ > ^ > /home/igor/qemu/hw/ppc/spapr_drc.c:683:5: note: in expansion of macro > ‘QTAILQ_FOREACH’ > QTAILQ_FOREACH(prop, &root_container->properties, node) { > ^ > /home/igor/qemu/include/qemu/queue.h:421:31: error: ‘ObjectProperty’ has > no member named ‘node’ > (var) = ((var)->field.tqe_next)) > ^ > /home/igor/qemu/hw/ppc/spapr_drc.c:683:5: note: in expansion of macro > ‘QTAILQ_FOREACH’ > QTAILQ_FOREACH(prop, &root_container->properties, node) { > ^ > /home/igor/qemu/rules.mak:57: recipe for target 'hw/ppc/spapr_drc.o' failed > make[1]: *** [hw/ppc/spapr_drc.o] Error 1 > Makefile:184: recipe for target 'subdir-ppc64-softmmu' failed > --- cut --- > > Actually, he was building version with my standalone patch, but i have > checked your series, it also doesn't touch SPAPR code.
Ah yes, I'll do an all-targets build and check this out. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|