Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads

[Stefan Hajnoczi]

On Mon, Oct 05, 2015 at 07:51:55PM -0400, Kevin O'Connor wrote:
> +static uint64_t fw_cfg_dma_mem_read(void *opaque, hwaddr addr,
> +                                    unsigned size)
> +{
> +    // Return a signature value (and handle various read sizes)
> +    return extract64(FW_CFG_DMA_SIGNATURE, (8 - addr - size) * 8, size*8);

Perhaps the maintainer can s/size*8/size * 8/ when applying this patch.

Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>