On Thu 17 Sep 2015 03:48:16 PM CEST, Kevin Wolf wrote: > @@ -1090,6 +1090,7 @@ static BdrvChild *bdrv_attach_child(BlockDriverState > *parent_bs, > }; > > QLIST_INSERT_HEAD(&parent_bs->children, child, next); > + QLIST_INSERT_HEAD(&child_bs->parents, child, next_parent); > > return child; > }
Ok, I'm probably slow today, but what is this used for? :-? And why is it called 'parents'? The list doesn't contain pointers to the parents of child_bs, but to child_bs itself... I would expect a BdrvChild *parent, with parent->bs = parent_bs. Berto
