Quoting Paolo Bonzini (2015-09-17 10:53:40) > > > On 17/09/2015 17:50, Michael Roth wrote: > > We still need globals for RTAS lookups. I think QOM is our most > > mature/well-tested interface for managing inter-device > > relationships/lookups, but I can understand if using > > root_container/link<DRC> seems off. To me it seem like a nice > > "freebie" we get from using QOM, and gave us nice guarantees like > > globally unique paths to correspond to globally unique DRC indexes. > > I think it's okay; but I don't really like looking at ->properties > directly, without an API (which doesn't exist indeed).
Yah, rather than copying qmp_qom_list() I think a proper interface would've been warranted. Perhaps an object_link_foreach() that mirrors object_child_foreach()? For maybe just a more generic object_foreach() with a type mask? Another approach would be to re-use or genericize qmp_qom_list() but that seems like extra allocations/cleanup that aren't really necessary outside of QMP/QAPI return values. > > Paolo >
