On 7 September 2015 at 10:56, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 07/09/2015 11:22, Peter Maydell wrote: >> On 7 September 2015 at 08:51, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> Coccinelle chokes on some idioms from compiler.h and queue.h. >>> Extract those in a macro file, to be used with "--macro-file >>> scripts/cocci-macro-file.h". >> >> Can we put the "how to use this" instructions in the file >> itself as well as in the commit message, please? > > Like this? > > /* Coccinelle only does limited parsing of headers, and chokes on some idioms > * defined in compiler.h and queue.h. Macros that Coccinelle must know about > * in order to parse .c files must be in a separate macro file---which is > * exactly what you're staring at now. > * > * To use this file, add the "--macro-file scripts/cocci-macro-file.h" to the > * Coccinelle command line. > */
Yeah, sounds about right. thanks -- PMM