On Fri, Sep 4, 2015 at 3:50 PM, Frederic Konrad
<fred.kon...@greensocs.com> wrote:
> On 01/09/2015 22:58, Alistair Francis wrote:
>>
>> On Tue, Jul 21, 2015 at 10:17 AM, <fred.kon...@greensocs.com> wrote:
>>>
>>> From: KONRAD Frederic <fred.kon...@greensocs.com>
>>>
>>> Seems this field is not needed.
>>
>> The commit message should be updated to represent the patch.
>
> Hmmm what do you mean?
> It's not precise?
Hey Fred,
The commit message should make sense without the commit title.
Thanks,
Alistair
>
> Thanks,
> Fred
>
>
>>
>>> Signed-off-by: KONRAD Frederic <fred.kon...@greensocs.com>
>>
>> Otherwise:
>>
>> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com>
>>
>> Thanks,
>>
>> Alistair
>>
>>> ---
>>> hw/i2c/core.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/hw/i2c/core.c b/hw/i2c/core.c
>>> index 5a64026..e0f92de 100644
>>> --- a/hw/i2c/core.c
>>> +++ b/hw/i2c/core.c
>>> @@ -13,7 +13,6 @@ struct I2CBus
>>> {
>>> BusState qbus;
>>> I2CSlave *current_dev;
>>> - I2CSlave *dev;
>>> uint8_t saved_address;
>>> };
>>>
>>> --
>>> 1.9.0
>>>
>>>
>
