On Fri, Aug 14, 2015 at 06:46:28PM +0100, Peter Maydell wrote: > This patch series splits scripts/qemu-gdb into separate > files for each command, to make it easier to add new > commands in future without them all going into a single > huge file. > > Patches 1 and 2 do that split, and have been on the list > before (and reviewed by Stefan). > > Patch 3 makes the script tell gdb not to stop on SIGUSR1, > since that's our SIGIPI and happens all the time. > > Patch 4 adds a brief comment explaining how to source the > script. NB that I haven't attempted to make the script > work with automatic-sourcing based on the executable > being debugged. Somebody who uses the script that way > can do that :-) > > I've dropped the script which added support for setting > breakpoints on QEMU tracepoints for the moment (pending > investigating static probe point support which might > render it unnecessary). Mostly I'd like to get these > into master so that future debug commands can go into > the right place -- IIRC David Gilbert had a patchset > which added another command. > > thanks > -- PMM > > Peter Maydell (4): > scripts/qemu-gdb: Split MtreeCommand into its own module > scripts/qemu-gdb: Split CoroutineCommand into its own file > scripts/qemu-gdb: Silently pass through SIGUSR1 > scripts/qemu-gdb: Add brief comment describing usage > > scripts/qemu-gdb.py | 146 > ++++--------------------------------------- > scripts/qemugdb/__init__.py | 28 +++++++++ > scripts/qemugdb/coroutine.py | 91 +++++++++++++++++++++++++++ > scripts/qemugdb/mtree.py | 82 ++++++++++++++++++++++++ > 4 files changed, 212 insertions(+), 135 deletions(-) > create mode 100644 scripts/qemugdb/__init__.py > create mode 100644 scripts/qemugdb/coroutine.py > create mode 100644 scripts/qemugdb/mtree.py > > -- > 1.9.1 >
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
