On 26 August 2015 at 20:04, Wei Huang <w...@redhat.com> wrote:
> This patch generates smbios tables for ARM mach-virt. Also add
> CONFIG_SMBIOS=y for ARM default config.
>
> Acked-by: Gabriel Somlo <so...@cmu.edu>
> Tested-by: Gabriel Somlo <so...@cmu.edu>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
> Reviewed-by: Shannon Zhao <shannon.z...@linaro.org>
> Tested-by: Leif Lindholm <leif.lindh...@linaro.org>
> Signed-off-by: Wei Huang <w...@redhat.com>
> +static void virt_build_smbios(VirtGuestInfo *guest_info)
> +{
> + FWCfgState *fw_cfg = guest_info->fw_cfg;
> + uint8_t *smbios_tables, *smbios_anchor;
> + size_t smbios_tables_len, smbios_anchor_len;
> +
> + if (!fw_cfg)
> + return;
Missing braces for if (). You can catch this sort of thing
yourself by running scripts/checkpatch.pl on your patches.
In this case this looks like the only issue with this patchset,
so I'll fix it when I put it into target-arm.next.
thanks
-- PMM
