On 27 August 2015 at 07:15, Laszlo Ersek <ler...@redhat.com> wrote: > On 08/26/15 21:04, Wei Huang wrote: >> This patch adds support for SMBIOS 3.0 entry point. When caller invokes >> smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then >> smbios_get_tables() will return the entry point table in right format. >> >> Acked-by: Gabriel Somlo <so...@cmu.edu> >> Tested-by: Gabriel Somlo <so...@cmu.edu> >> Tested-by: Leif Lindholm <leif.lindh...@linaro.org> >> Signed-off-by: Wei Huang <w...@redhat.com> >> --- >> hw/i386/pc_piix.c | 3 +- >> hw/i386/pc_q35.c | 3 +- >> hw/smbios/smbios.c | 84 >> +++++++++++++++++++++++++++++++++------------- >> include/hw/smbios/smbios.h | 62 ++++++++++++++++++++++++++-------- >> tests/bios-tables-test.c | 6 ++-- >> 5 files changed, 116 insertions(+), 42 deletions(-) > > Diffed against v4. > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > (although my reviews are obviously not the bottleneck here, so I wonder > why I bother at all)
Just a note to say that I do appreciate the code review, especially as here when the patches deal with something that's not my area of expertise. thanks -- PMM
