On 08/04/2015 09:58 AM, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use more consistent and sensible variable names. > > Consistently use c_ for mapping keys when their value is a C > identifier or type. > > Simplify gen_enum() and gen_visit_union() > > Consistently use single quotes for C text string literals. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > docs/qapi-code-gen.txt | 2 +- > scripts/qapi-commands.py | 129 +++++++++++++++++++++++----------------------- > scripts/qapi-event.py | 121 ++++++++++++++++++++----------------------- > scripts/qapi-types.py | 64 +++++++++++------------ > scripts/qapi-visit.py | 119 +++++++++++++++++++++--------------------- > scripts/qapi.py | 131 > +++++++++-------------------------------------- > 6 files changed, 239 insertions(+), 327 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
