Eric Blake <ebl...@redhat.com> writes:
> On 08/04/2015 09:58 AM, Markus Armbruster wrote:
>> is_c_ptr() looks whether the end of the C text for the type looks like
>> a pointer. Works, but is fragile.
>>
>> We now have a better tool: use QAPISchemaType method c_null(). The
>> initializers for non-pointers become prettier: 0, false or the
>> enumeration constant with the value 0 instead of {0}.
>>
>> One place looks suspicious: we initialize pointers, but not
>> non-pointers. Either the initialization is superfluous and should be
>> deleted, or the non-pointers need it as well, or something subtle is
>> going on and needs a comment. Since I lack the time to figure it out
>> now, mark it FIXME.
>
> Dead paragraph.
The pre KVM Forum time crunch shows %-}
Will drop.
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> scripts/qapi-commands.py | 16 +++++-----------
>> scripts/qapi.py | 3 ---
>> 2 files changed, 5 insertions(+), 14 deletions(-)
>>
>
> With fixed commit message,
> Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks!
