On Mon, May 03, 2010 at 11:59:55AM -0500, Anthony Liguori wrote: > On 05/03/2010 04:29 AM, Markus Armbruster wrote: > >Why am I proposing to remove pci_add from QMP before its replacement is > >ready? I want it out sooner rather than later, because it isn't fully > >functional (errors and drive_add are missing), and we do not plan to > >complete the job. In other words, it's not really usable over QMP now, > >and it's not what we want for QMP anyway. Since we don't want it to be > >used over QMP, we should take it out, not leave it around as a trap for > >the uninitiated. > > > >Anyway, I'll respin with a more verbose commit message, and I'll throw > >in the buddy patch Revert "monitor: Convert do_pci_device_hot_remove() > >to QObject". > > > > Does libvirt not use pci_add with QMP?
As of QEMU 0.12, libvirt uses -device syntax for everything. As of QEMU 0.13, libvirt will use QMP for everything (if compiled with the libyajl JSON library - otherwise text mode only). When -device is in use, we use device_add exclusively. Therefore, we will have no need for pci_add & friends when using QMP. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
