Anthony Liguori <anth...@codemonkey.ws> writes:
> On 05/03/2010 04:29 AM, Markus Armbruster wrote:
[...]
>> Why am I proposing to remove pci_add from QMP before its replacement is
>> ready? I want it out sooner rather than later, because it isn't fully
>> functional (errors and drive_add are missing), and we do not plan to
>> complete the job. In other words, it's not really usable over QMP now,
>> and it's not what we want for QMP anyway. Since we don't want it to be
>> used over QMP, we should take it out, not leave it around as a trap for
>> the uninitiated.
>>
>> Anyway, I'll respin with a more verbose commit message, and I'll throw
>> in the buddy patch Revert "monitor: Convert do_pci_device_hot_remove()
>> to QObject".
>>
>
> Does libvirt not use pci_add with QMP?
Re QMP in general: libvirt has code for QMP, but it is disabled. It'll
get enabled as soon as a usable QMP ships, which we all expect for the
next release.
Re pci_add over QMP, git://libvirt.org/libvirt.git has:
commit efd4ee7871a631a9293e94d58fc4384c162388a7
Author: Daniel P. Berrange <berra...@redhat.com>
Date: Wed Apr 14 15:23:38 2010 +0100
Remove code from JSON monitor for commands that won't be ported
The QEMU developers have stated that they will not be porting
the commands 'pci_add', 'pci_del', 'usb_add', 'usb_del' to the
JSON mode monitor, since they're obsoleted by 'device_add'
and 'device_del'. libvirt has (untested) code that would have
supported those commands in theory, but since we already use
device_add/del where available, there's no need to keep the
legacy stuff anymore.
The text mode monitor keeps support for all commands for sake
of historical compatability.
* src/qemu/qemu_monitor_json.c: Remove 'pci_add', 'pci_del',
'usb_add', 'usb_del' commands
Does this answer your question?
