On Tue, Jul 07, 2015 at 02:30:30PM +0800, Fam Zheng wrote: > This moves the semantics from net_hub_port_can_receive to receive > functions, by returning 0 if all receiving ports return 0. Also, > remember to flush the source port's queue in that case. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > net/hub.c | 54 +++++++++++++++++++++++++++++------------------------- > 1 file changed, 29 insertions(+), 25 deletions(-)
This patch revision doesn't take into account the special case code in qemu_flush_or_purge_queued_packets(), which I mentioned in my reply to the previous revision of this patch. The queue is now flushed twice because you've introduced net_hub_port_send_cb() but qemu_flush_or_purge_queued_packets() already calls net_hub_flush(). If you want to get rid of net_hub_flush(), that's great. But please remove the duplicate code.
pgpqt14tcERsI.pgp
Description: PGP signature
