Am 25.06.2015 um 18:02 schrieb Paolo Bonzini:
> On 25/06/2015 18:00, Andreas Färber wrote:
>>> - if (!mmio_registered) {
>>> - ICCBus *b = ICC_BUS(qdev_get_parent_bus(dev));
>>> - memory_region_add_subregion(b->apic_address_space, 0,
>>> &s->io_memory);
>>> - mmio_registered = true;
>>> - }
>>> +
>>> + root = address_space_root_memory_region(cpu->as);
>>> + memory_region_add_subregion_overlap(root,
>>> + s->apicbase &
>>> MSR_IA32_APICBASE_BASE,
>>> + &s->io_memory,
>>> + 0x1000);
>>>
>
> I had already remarked that this patch is wrong. cpu->as is completely
> unused on KVM, for example.
Ah, then I don't understand this [RESEND]. ;)
Either way, not on my plate ATM, it seems.
Did you also outline how it is supposed to be done instead?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
