On 25/06/2015 18:00, Andreas Färber wrote:
>> - if (!mmio_registered) {
>> - ICCBus *b = ICC_BUS(qdev_get_parent_bus(dev));
>> - memory_region_add_subregion(b->apic_address_space, 0,
>> &s->io_memory);
>> - mmio_registered = true;
>> - }
>> +
>> + root = address_space_root_memory_region(cpu->as);
>> + memory_region_add_subregion_overlap(root,
>> + s->apicbase &
>> MSR_IA32_APICBASE_BASE,
>> + &s->io_memory,
>> + 0x1000);
>>
I had already remarked that this patch is wrong. cpu->as is completely
unused on KVM, for example.
Paolo
