Am 21.04.2010 17:39, schrieb Juan Quintela: > Luiz Capitulino <lcapitul...@redhat.com> wrote: >> 2. Don't keep the VM paused when recovery is possible >> >> If you can fix that, it's ok to me: I'll drop this and the next patch. >> >> Otherwise I'll have to insist on the split. > > Re-read my email. At this point, nothing is fixable :( After doing > the 1st: > >>> ret = bdrv_snapshot_goto(bs1, name); > > and not returning an error -> state has changed, period. You can't > restart the machine.
Right, at this point. But the most likely error for bdrv_snapshot_goto is that the snapshot doesn't even exist. This is something that you can check before you change any state. I think this is what Luiz meant (at least it is what I said and he agreed). Kevin
