On Mon, 1 Jun 2015 10:38:32 -0300 "Paulo Alcantara" <pca...@zytor.com> wrote:
> On Mon, June 1, 2015 6:05 am, Paolo Bonzini wrote: > > > > > > On 31/05/2015 00:04, Paulo Alcantara wrote: > >> + case TCO_RLD: > >> + tr->timeouts_no = 0; > >> + if (can_start_tco_timer(tr)) { > >> + tr->tco.rld = tr->tco.tmr; > >> + tco_timer_reload(tr); > >> + } else { > >> + tr->tco.rld = val; > > > > Please mask out bits outside TCO_RLD_MASK here, same as you do for > > TCO1_STS_MASK and friends. > > OK. Hrm - actually, I can't do that. Unlike TCO1_STS, TCO2_STS and TCO1_CNT registers that have some bits which are disabled by writing 1 to them -- that's why I mask them out before updating -- the TCO_RLD and TCO_TMR registers only have bits 15:10 marked as _reserved_ and I should not zero them out. Does that seem correct to you? Thanks, Paulo -- Paulo Alcantara, C.E.S.A.R Speaking for myself only.