On 05/19/2015 11:30 AM, Kashyap Chamarthy wrote: > On Mon, May 18, 2015 at 06:22:22PM +0200, Max Reitz wrote: >> On 12.05.2015 01:04, John Snow wrote: >>> From: Kashyap Chamarthy <kcham...@redhat.com> >>> >>> Although the canonical source of reference for QMP commands is >>> qapi-schema.json, for consistency's sake, update qmp-commands.hx to >>> state the list of supported transactionable operations, namely: >>> >>> drive-backup >>> blockdev-backup >>> blockdev-snapshot-internal-sync >>> abort >>> block-dirty-bitmap-add >>> block-dirty-bitmap-clear >>> >>> Signed-off-by: Kashyap Chamarthy <kcham...@redhat.com> >>> Reviewed-by: Eric Blake <ebl...@redhat.com> >>> Signed-off-by: John Snow <js...@redhat.com> >>> --- >>> qmp-commands.hx | 13 ++++++++----- >>> 1 file changed, 8 insertions(+), 5 deletions(-) >>> >>> diff --git a/qmp-commands.hx b/qmp-commands.hx >>> index 7506774..363126a 100644 >>> --- a/qmp-commands.hx >>> +++ b/qmp-commands.hx >>> @@ -1238,11 +1238,14 @@ SQMP >>> transaction >>> ----------- >>> -Atomically operate on one or more block devices. The only supported >>> operations >>> -for now are drive-backup, internal and external snapshotting. A list of >>> -dictionaries is accepted, that contains the actions to be performed. >>> -If there is any failure performing any of the operations, all operations >>> -for the group are abandoned. >>> +Atomically operate on one or more block devices. Operations that are >>> +currently supported: drive-backup, blockdev-backup, >>> +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, >>> +block-dirty-bitmap-add, block-dirty-bitmap-clear >> >> Hm, seven operations... Worth making it a real list? > > I don't have a preference. FWIW, I think it still retains the > readability. And, not sure if it's worth the churn. > >>> (refer to the >>> +qemu/qapi-schema.json file for minimum required QEMU versions for these >>> +operations). A list of dictionaries is accepted, that contains the >>> +actions to be performed. If there is any failure performing any of the >>> +operations, all operations for the group are abandoned. >>> For external snapshots, the dictionary contains the device, the file to >>> use for >>> the new snapshot, and the format. The default format, if not specified, is >> >
I have to respin the series anyway, so if you want Kashyap, you can rewrite this and send it to me privately for inclusion, or I'll just edit it myself. --js
