On 07/05/2015 13:35, Liviu Ionescu wrote: > >> On 07 May 2015, at 15:21, Leon Alrae <leon.al...@imgtec.com> wrote: >> >> On 07/05/2015 12:50, Liviu Ionescu wrote: >>> >>>> On 07 May 2015, at 12:52, Leon Alrae <leon.al...@imgtec.com> wrote: >>>> >>>>> is it that difficult to count the "arg"s and correctly alloc the array? >>>> >>>> This probably would require going through the list twice >>> >>> the code to iterate is already there, for other options, you just need to >>> add a branch to the existing case. >> >> Do you mean modifying QEMU option parser? > > not at all. > > option parsing is done anyway in two passes. the first pass is a short loop, > used to identify nodeconfig & nouserconfig. the second pass is the big > for(;;) loop. you can use this first pass to count the number of args, > similarly as I did in my patch. >
I think parsing -semihosting-config sub-options should happen inside "case QEMU_OPTION_semihosting_config", just to be consistent with other options. Leon
