On 06/05/2015 16:22, Liviu Ionescu wrote:
>
> apparently your patch does not fix the arm semihosting problems. do you plan
> a separate patch for this?
This patchset doesn't contain any target semihosting specific changes
(just a clean up and new arg option). I'm going to follow up with UHI
patch series only. I don't have anything set up to test other
semihosting interfaces, thus I don't plan to do any changes in these
areas in near future. Therefore feel free to send your ARM semihosting
improvements.
>
>
>> bool semihosting_enabled(void)
>> {
>> return semihosting.allowed;
>> }
>
> any particular reason for naming the structure member ".allowed" and the
> getter function "_enabled()"?
Generally no, but patch #1 introduced semihosting_enabled() function,
hence this change. However, thanks for pointing this out as I just
realized that with the patch #3 this rename was not required at all.
I'll correct that.
Thanks,
Leon
