On 04/04/2015 10:07 PM, Eric Blake wrote: > Go into more details about the various types of valid expressions > in a qapi schema, including tweaks to document fixes being done > later in the current patch series. Also fix some stale and missing > documentation in the QMP specification. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > ---
Another self-review: > +generated C structs and parameter lists). Ordering doesn't matter > +between top-level expressions or the keys within an expression, but > +does matter within dictionary values for 'data' and 'returns' members > +of a single expression. QAPI schema input is written using 'single > +quotes' instead of JSON's "double quotes" (in contrast, QMP usage is > +strict JSON and only uses "double quotes", with no comments). As in > +JSON, trailing commas are not permitted in arrays or dictionaries. > +Input must be ASCII (although QMP supports full Unicode strings, the > +QAPI parser does not). At present, there is no place where a QAPI > +schema requires the use of JSON numbers or null. Here I claim that QMP is "" only... > +++ b/docs/qmp/qmp-spec.txt > + > +Also for convenience, the server will accept an extension of > +'single-quoted' strings in place of the usual "double-quoted" > +json-string, and both input forms of strings understand an additional > +escape sequence of "\'" for a single quote. The server will only use > +double quoting on output. ...which is at odds with reality. Will fix in either a followup or a v7 respin -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
