Am 23.03.2015 um 16:11 schrieb Peter Maydell: > On 23 March 2015 at 14:39, Paolo Bonzini <pbonz...@redhat.com> wrote: >> On 23/03/2015 13:24, Peter Maydell wrote: >>> * cpu_physical_memory_rw are obsolete and should be replaced >>> with uses of the as_* functions -- we should at least note >>> this in the header file. (Can't do this as an automated change >>> really because the correct AS to use is callsite dependent.) >> >> All users that should _not_ be using address_space_memory have been >> already changed to address_space_rw, or should have, so it can be done >> automatically. Same for cpu_physical_memory_map/unmap, BTW. > > Hmm. Checking a few, I notice that for instance the kvm-all.c > cpu_physical_memory_rw() should probably be using cpu->as. [snip]
Igor, does that impact our APIC discussion? Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
