On 23 March 2015 at 15:27, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 23/03/2015 16:26, Peter Maydell wrote: >> > True. But since it's not a new API we can keep the old name for the >> > simple one. >> >> ...except that means that the function you should in >> general not be using as default is the one with the short >> name, which is the wrong way round. We should be guiding >> people writing new code to think about the required >> behaviour on memory transaction failure (and attributes) >> as they write the code, not making it easy for them to >> ignore the issue... > > Not necessarily, for example PCI devices can certainly > use the short name.
PCI devices should all be using ld*_pci_dma and st*_pci_dma so they go through the correct address space for the PCIDevice. Any PCI device making direct calls to ld*_phys/st*_phys is broken... -- PMM
