This is a small series of fixes for the VNC server. The primary focus was on fixing the handling of TLS + auth in the websockets server so that it can actually be used in real world scenarios. These prepare the way for work I'm doing to refactor TLS handling into a module that is reusable across QEMU.
Changed in v2: - Improve error reporting when VNC feature is disabled at build time - Move VNC auth scheme setup into separate method - Split the 3rd patch up into 4 pieces Daniel P. Berrange (8): ui: remove unused 'wiremode' variable in VncState struct ui: replace printf() calls with VNC_DEBUG ui: report error if user requests VNC option that is unsupported ui: split setup of VNC auth scheme into separate method ui: fix setup of VNC websockets auth scheme with TLS ui: enforce TLS when using websockets server ui: remove separate gnutls_session for websockets server ui: ensure VNC websockets server checks the ACL if requested ui/vnc-auth-vencrypt.c | 1 - ui/vnc-tls.c | 72 +++++-------- ui/vnc-tls.h | 7 -- ui/vnc-ws.c | 46 ++++---- ui/vnc-ws.h | 2 +- ui/vnc.c | 287 +++++++++++++++++++++++++++++-------------------- ui/vnc.h | 9 +- 7 files changed, 222 insertions(+), 202 deletions(-) -- 2.1.0
