On 16.03.2015 16:01, Paolo Bonzini wrote: > > > On 16/03/2015 15:45, Eric Blake wrote: >> On 03/16/2015 04:31 AM, hw.clau...@gmail.com wrote: >>> From: Claudio Fontana <claudio.font...@huawei.com> >>> >>> usage is similar to the commands x, xp. >>> >>> Example with string: looking for "ELF" header in memory: >>> >>> (qemu) s/1000000cb 0x40001000 "ELF" searching memory area >>> [0000000040001000-00000000400f5240] 0000000040090001 (qemu) x/20b >>> 0x40090000 0000000040090000: '\x7f' 'E' 'L' 'F' '\x02' '\x01' >>> '\x01' '\x03' 0000000040090008: '\x00' '\x00' '\x00' '\x00' >>> '\x00' '\x00' '\x00' '\x00' 0000000040090010: '\x02' '\x00' >>> '\xb7' '\x00' >>> >>> Example with value: looking for 64bit variable value 0x990088 >>> >>> (qemu) s/1000000xg 0xffff900042000000 0x990088 searching memory >>> area [ffff900042000000-ffff9000427a1200] ffff9000424b3000 >>> ffff9000424c1000 >>> >>> Signed-off-by: Claudio Fontana <claudio.font...@huawei.com> --- >>> hmp-commands.hx | 28 ++++++++++++ monitor.c | 140 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files >>> changed, 168 insertions(+) >>> >>> Hello, looking for some comments on whether the addition of this >>> command is welcome, and whether the syntax chosen is acceptable, >>> or how it can made better. >> >> Do you want to provide a QMP counterpart? In general, we are >> reluctant to add new HMP functionality that cannot also be accessed >> via QMP. > > I think this is okay for a debugging command. x and xp do not have an > QMP equivalent either. > > Paolo >
Just let me know if necessary (personally I would not have a use for a QMP counterpart). Thanks, Claudio -- Claudio Fontana Server Virtualization Architect Huawei Technologies Duesseldorf GmbH Riesstraße 25 - 80992 München office: +49 89 158834 4135 mobile: +49 15253060158
