PATCH 3/4 changes syntax of set_link's second argument from up|down to on|off. I feel that the argument needs to be boolean in QMP, and this is the simplest way to get it. Luiz likes this approach. The change doesn't affect libvirt, because it doesn't use set_link, yet.
Alternatives I could try if the syntax change is unwanted: * Use the old string argument in QMP. Easy. * Don't convert set_link, create a new command with a boolean argument. * Create a argument parser for up|down. v2: Fix parsing of 'on' and 'off' in PATCH 2/4. Markus Armbruster (4): monitor: Rename argument type 'b' to 'f' monitor: New argument type 'b' monitor: Use argument type 'b' for set_link monitor: Convert do_set_link() to QObject, QError monitor.c | 39 +++++++++++++++++++++++++++++++++++---- net.c | 17 ++++++----------- net.h | 2 +- qemu-monitor.hx | 13 +++++++------ 4 files changed, 49 insertions(+), 22 deletions(-)