On 02/17/2015 03:19 AM, Kevin Wolf wrote:
>> if (num_fixed) {
>> ret = update_refcount(bs, i << s->cluster_bits, 1,
>> - refcount2 - refcount1,
>> + (int)refcount2 - (int)refcount1,
>> QCOW2_DISCARD_ALWAYS);
>> if (ret >= 0) {
>> (*num_fixed)++;
>
> Wouldn't both refcounts be promoted to int anyway, even without a cast?
> But then, being explicit probably can't hurt either.But it all goes away in the next patch that switches to uint64_t, so I don't mind the temporary ugliness. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
