On 02/04/2015 11:01 AM, Eric Blake wrote: > On 02/04/2015 10:51 AM, Eric Blake wrote: >> From: Stefan Hajnoczi <stefa...@redhat.com> >> >> The block.c file has grown to over 6000 lines. It is time to split this >> file so there are fewer conflicts and the code is easier to maintain. >>
>> This patch produces identical results to Stefan's email, but is >> MUCH more readable (hint: git config diff.algorithm patience) >> >> block.c | 1980 >> +------------------------------------------- >> block/Makefile.objs | 1 + >> block/io.c | 1997 >> +++++++++++++++++++++++++++++++++++++++++++++ >> include/block/block_int.h | 14 + >> 4 files changed, 2015 insertions(+), 1977 deletions(-) >> create mode 100644 block/io.c > > And here's how I reviewed it: > $ git format-patch --stdout -1 > patch > $ diff -u <(sed -n 's/^-//p' patch) <(sed -n 's/^\+//p' patch) I've updated http://wiki.qemu.org/Contribute/SubmitAPatch with this hint. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature