Board setup should normally use qdev_init_nofail(), not qdev_init(), because inability to create an onboard device is normally fatal. Board setup should certainly not ignore qdev_init() failure. Even when we know that realization can't actually fail now, qdev_init_nofail() is clearer and more robust. Correct a few obvious instances.
Markus Armbruster (8): qdev: Improve qdev_init_nofail()'s error reporting ide/isa: Replace unchecked qdev_init() by qdev_init_nofail() leon3: Replace unchecked qdev_init() by qdev_init_nofail() etsec: Replace qdev_init() by qdev_init_nofail() serial: Factor out common serial_hds_isa_init() serial: serial_hds_isa_init() shouldn't fail parallel: Factor out common parallel_hds_isa_init() parallel: parallel_hds_isa_init() shouldn't fail hw/alpha/dp264.c | 6 +----- hw/char/parallel.c | 25 +++++++++++++++++++++++++ hw/char/serial-isa.c | 23 +++++++++++++++-------- hw/core/qdev.c | 11 ++++++++--- hw/i386/pc.c | 13 ++----------- hw/ide/isa.c | 4 +--- hw/mips/mips_fulong2e.c | 12 ++---------- hw/mips/mips_malta.c | 7 +++---- hw/mips/mips_r4k.c | 6 +----- hw/net/fsl_etsec/etsec.c | 5 +---- hw/sparc64/sun4u.c | 12 ++---------- include/hw/char/serial.h | 2 +- include/hw/i386/pc.h | 17 +---------------- include/hw/sparc/grlib.h | 12 +++--------- 14 files changed, 66 insertions(+), 89 deletions(-) -- 1.9.3
