On 29 January 2015 at 19:47, Laszlo Ersek <ler...@redhat.com> wrote: > On 01/29/15 20:12, Laszlo Ersek wrote: >> If the guest kernel changed its "assignment strategy" at some point, but >> earlier it used to match the comment (and the code), then whichever way >> we shape the comment will be wrong for the other kernel strategy. :) So, >> in that case this code is probably best left undisturbed. >> >> I'll try to dig out some kernel commit for more evidence. > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=70161ff3
Thanks for digging that up -- I was half-thinking we might just have got it wrong two years ago when we wrote the code :-) We should probably update the comment to say (a) what we were trying to do (b) that we don't want to change it now because it would break existing setups. -- PMM
