Ekaterina Tumanova <tuman...@linux.vnet.ibm.com> writes: > On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote: [...] >> 3. Why does s390 need to customize hd_geometry_guess()? >> > Since hd_geometry_guess contains semantics of x86-specific LBA > translation, we have to modify it not to get in the way of z > architecture
I already explained this in my review, but it's buried among other stuff, so let me repeat it here: The only caller that passes non-null ptrans to hd_geometry_guess() is ide_dev_initfn(), and the only user of the value that gets stored there is pc_cmos_init_late(). We store a highly PC-specific value there. That's okay, it's used only by PC machines. The whole concept "BIOS translation" makes no sense for other machines. Heck, it makes barely sense even on PCs.
