On 11/25/2014 04:01 PM, Stefan Hajnoczi wrote:
On Wed, Nov 19, 2014 at 11:17:50AM +0100, Ekaterina Tumanova wrote:
Hi folks,
I'm sorry for the recent spam. I messed up during code submission last time.
So please ignore any previous notes you received from me and answer only to
this thread.
This is the rework of the geometry+blocksize patch, which was
recently discussed here:
http://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01148.html
Markus suggested that we only detect blocksize and geometry for DASDs.
According to this agreement new version contains DASD special casing.
The driver methods are implemented only for "host_device" and inner hdev_xxx
functions check if the backing storage is a DASD by means of
BIODASDINFO2 ioctl.
Original patchset can be found here:
http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg03791.html
This is description is mainly a changelog. Links to previous email
threads are useful for additional info but please include a
self-contained description of the series and the rationale behind it.
will include into the next version
Comments:
1. This series overrides the logical_block_size and
physical_block_size options for raw images on DASD devices. Users
expect their command-line options to be honored, so the options
should not be overriden if they have been given on the command-line.
will fix that
2. Only virtio_blk is modified, this is inconsistent. All emulated
storage controllers using BlockConf have the same block size
probing behavior.
I will add blkconf_blocksizes call to other BlockConf users.
3. Why does s390 need to customize hd_geometry_guess()?
Since hd_geometry_guess contains semantics of x86-specific LBA
translation, we have to modify it not to get in the way of z
architecture
4. Please use scripts/checkpatch.pl to check coding style.
I did :)
Thanks a lot,
Kate.
