Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is an user error, do not allow the device to be hot-plugged.
v2 -> v3: - Reverse the decision to forbit the hotplug on user error (Michael S. Tsirkin) - Split the patch in two, first part being a separate fix (Markus Armbruster) v1 -> v2: After a discussion with Michael, Paolo and Alex, this patch silent drops the romfile instead of not allowing the hotplug. Marcel Apfelbaum (2): hw/pci: fixed error flow in pci_qdev_init hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile hw/pci/pci.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 1.8.3.1