On 9/15/2014 10:03 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> v1->v2: fixed leak of temporaries
>
> target-ppc/translate.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index c28bddf..a8b6b7c 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -252,23 +252,22 @@ static inline void gen_reset_fpstatus(void)
>
> static inline void gen_compute_fprf(TCGv_i64 arg, int set_fprf, int set_rc)
> {
> - TCGv_i32 t0 = tcg_temp_new_i32();
> + TCGv_i32 t0;
>
> - if (set_fprf != 0) {
> - /* This case might be optimized later */
> - tcg_gen_movi_i32(t0, 1);
> - gen_helper_compute_fprf(t0, cpu_env, arg, t0);
> - if (unlikely(set_rc)) {
> - tcg_gen_mov_i32(cpu_crf[1], t0);
> - }
> - gen_helper_float_check_status(cpu_env);
> - } else if (unlikely(set_rc)) {
> - /* We always need to compute fpcc */
> - tcg_gen_movi_i32(t0, 0);
> - gen_helper_compute_fprf(t0, cpu_env, arg, t0);
> + if (set_fprf == 0 && !set_rc) {
> + return;
> + }
> +
> + t0 = tcg_temp_new_i32();
> + tcg_gen_movi_i32(t0, set_fprf != 0);
> + gen_helper_compute_fprf(t0, cpu_env, arg, t0);
> + if (set_rc) {
> tcg_gen_mov_i32(cpu_crf[1], t0);
> }
>
> + if (set_fprf != 0) {
> + gen_helper_float_check_status(cpu_env);
> + }
> tcg_temp_free_i32(t0);
> }
>
>
Reviewed-by: Tom Musta <tommu...@gmail.com>
