The Friday 05 Sep 2014 à 16:07:15 (+0200), Max Reitz wrote :
> Not every BLOCK_IMAGE_CORRUPTED event must be fatal; for example, when
> reading from an image, they should generally not be. Nonetheless, even
> an image only read from may of course be corrupted and this can be
> detected during normal operation. In this case, a non-fatal event should
> be emitted, but the image should not be marked corrupt (in accordance to
> "fatal" set to false).
>
> Signed-off-by: Max Reitz <mre...@redhat.com>
> ---
> block/qcow2-refcount.c | 1 +
> qapi/block-core.json | 9 +++++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 43665b8..0bd75d2 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1853,6 +1853,7 @@ int qcow2_pre_write_overlap_check(BlockDriverState *bs,
> int ign, int64_t offset,
> offset,
> true,
> size,
> + true,
What is this line ?
> &error_abort);
> g_free(message);
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index a685d02..d23bcc2 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1554,7 +1554,7 @@
> ##
> # @BLOCK_IMAGE_CORRUPTED
> #
> -# Emitted when a disk image is being marked corrupt
> +# Emitted when a corruption has been detected in a disk image
> #
> # @device: device name
> #
> @@ -1568,13 +1568,18 @@
> # @size: #optional, if the corruption resulted from an image access, this is
> # the access size
> #
> +# fatal: if set, the image is marked corrupt and therefore unusable after
> this
> +# event and must be repaired (Since 2.2; before, every
> +# BLOCK_IMAGE_CORRUPTED event was fatal)
> +#
> # Since: 1.7
> ##
> { 'event': 'BLOCK_IMAGE_CORRUPTED',
> 'data': { 'device' : 'str',
> 'msg' : 'str',
> '*offset': 'int',
> - '*size' : 'int' } }
> + '*size' : 'int',
> + 'fatal' : 'bool' } }
>
> ##
> # @BLOCK_IO_ERROR
> --
> 2.1.0
>
>
