On 2014/8/30 13:26, Michael Tokarev wrote: > 30.08.2014 07:36, john.liuli wrote: >> From: Li Liu <john.li...@huawei.com> >> >> All qerror_report_err returned none NULL pointers need to >> be freed, otherwise will cause memory leaking. >> >> Although this place did not cause real memory leaking by exit, >> obviously it's not correct to use qerror_report_err >> without error_free it. > > I don't thing there's any good reason to free resources like > this (freeing memory, closing files, etc) right before exit() > (esp. in error path). The OS will do that for us in one go > much faster. >
Yes, the OS will do that for us. But if someone refer to this code to use qerror_report_err, it will give a bad hint. Of cause this patch is just a suggestion. Best regards Li. > /mjt > >
