From: Gonglei <arei.gong...@huawei.com> $WHATEVER: don't use 'Yoda conditions'
'Yoda conditions' are not part of idiomatic QEMU coding style, so rewrite them in the more usual order. v5: - rebase on latest qemu master and adding 'reviewed-by'. - Cc'ing qemu-trivial@. v4: - trivial typo for patch 1/8 suggested by Eric, thanks. v3: - rewrite CODINT_STYLE file suggested by Eric, thanks. - rename the patch serials. - imitate nearby code about using '!value' or 'value == NULL' at every patch suggested by Markus. v2: - add more specific commit messages suggested by PMM, thanks. - introduce section of conditional statement to CODING_STYLE. Gonglei (8): CODING_STYLE: Section about conditional statement usb: don't use 'Yoda conditions' audio: don't use 'Yoda conditions' isa-bus: don't use 'Yoda conditions' don't use 'Yoda conditions' spice: don't use 'Yoda conditions' vl: don't use 'Yoda conditions' vmxnet3: don't use 'Yoda conditions' CODING_STYLE | 14 ++++++++++++++ hw/audio/gus.c | 2 +- hw/audio/hda-codec.c | 3 ++- hw/audio/sb16.c | 6 +++--- hw/isa/isa-bus.c | 2 +- hw/net/vmxnet3.c | 16 ++++++++-------- hw/usb/dev-audio.c | 2 +- hw/usb/dev-mtp.c | 4 ++-- hw/usb/hcd-ehci.c | 2 +- qdev-monitor.c | 2 +- qemu-char.c | 2 +- ui/spice-core.c | 4 ++-- util/qemu-sockets.c | 2 +- vl.c | 5 +++-- 14 files changed, 41 insertions(+), 25 deletions(-) -- 1.7.12.4
