On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > + > + /* GPR Register */ > + target_ulong gpr_a[16]; > + target_ulong gpr_d[16]; > +}; > + > +typedef struct tricore_def_t tricore_def_t; > + > +typedef struct CPUTRICOREState CPUTRICOREState; > +struct CPUTRICOREState { > + TCState active_tc;
You'll get better code generation if you put the gprs first. Some hosts will need a 2 insn sequence for large offsets, and even x86 will have a code size benefit from having offsets < 128. Is there any real need for the active_tc thing, or did you just copy MIPS? Personally, I dislike it, and unless you're planning on using structure assignment to copy data around during certain context switches, please drop it. r~