On 06/26/2014 09:50 PM, Hu Tao wrote: > On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: >> On 06/26/2014 12:13 AM, Hu Tao wrote: >>> We already have ROUND_UP but there are similar macros and ROUND_UP-like >>> lines all around, replace them with ROUND_UP and clean up similar macros. >>> >>> Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> >>> --- >> >> All of these conversions are correct, so: >> Reviewed-by: Eric Blake <ebl...@redhat.com> > > Thanks for review!
>> tcg/ppc/tcg-target.c-#define FRAME_SIZE ((TCG_TARGET_CALL_STACK_OFFSET \ >> tcg/ppc/tcg-target.c- + TCG_STATIC_CALL_ARGS_SIZE \ >> tcg/ppc/tcg-target.c- + CPU_TEMP_BUF_SIZE \ >> tcg/ppc/tcg-target.c- + REG_SAVE_SIZE \ >> tcg/ppc/tcg-target.c- + TCG_TARGET_STACK_ALIGN - 1) \ >> tcg/ppc/tcg-target.c: & -TCG_TARGET_STACK_ALIGN) > > How did you find this one? Your pattern below just shows the last line. But the last line had the word ALIGN in it, so I looked at the context and found that it was indeed a rounding operation. >> before I quit looking for more. (I just manually read through >> git grep '[^&]& [~-]' >> which has a lot of noise for non-rounding uses, but definitely found >> some missed cases) Are you going to submit a v2? As this does not appear to be a bug fix, and today is hard freeze, this is probably 2.2 material. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
