On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: > On 06/26/2014 12:13 AM, Hu Tao wrote: > > We already have ROUND_UP but there are similar macros and ROUND_UP-like > > lines all around, replace them with ROUND_UP and clean up similar macros. > > > > Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> > > --- > > All of these conversions are correct, so: > Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks for review! > > However, without documenting how you found what to convert, I'm quite > sure you missed some conversions. In fact, I found at least: > > util/oslib-win32.c: memory = (memory + pagesize - 1) & -pagesize; The pattern I used is '(.*+.*\-.*\&.*~'. Apparently I forgot the -pagesize case. > > tcg/ppc/tcg-target.c-#define FRAME_SIZE ((TCG_TARGET_CALL_STACK_OFFSET \ > tcg/ppc/tcg-target.c- + TCG_STATIC_CALL_ARGS_SIZE \ > tcg/ppc/tcg-target.c- + CPU_TEMP_BUF_SIZE \ > tcg/ppc/tcg-target.c- + REG_SAVE_SIZE \ > tcg/ppc/tcg-target.c- + TCG_TARGET_STACK_ALIGN - 1) \ > tcg/ppc/tcg-target.c: & -TCG_TARGET_STACK_ALIGN) How did you find this one? Your pattern below just shows the last line. > > block/cow.c: s->cow_sectors_offset = (bitmap_size + 511) & ~511; > > block/qcow.c: header_size = (header_size + 7) & ~7; > > before I quit looking for more. (I just manually read through > git grep '[^&]& [~-]' > which has a lot of noise for non-rounding uses, but definitely found > some missed cases) > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
