Il 28/05/2014 14:21, Gonglei (Arei) ha scritto:
-----Original Message-----
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
Bonzini
Sent: Tuesday, May 27, 2014 9:34 PM
To: Gonglei (Arei); qemu-devel@nongnu.org
Cc: kw...@redhat.com; peter.crosthwa...@xilinx.com; Huangweidong (C);
aligu...@amazon.com; m...@redhat.com; Luonengjun; arm...@redhat.com;
lcapitul...@redhat.com; qiaonuo...@cn.fujitsu.com; av1...@comtv.ru;
kra...@redhat.com; stefa...@redhat.com; crobi...@redhat.com;
ler...@redhat.com; afaer...@suse.de
Subject: Re: [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in
tight_detect_smooth_image{16, 24, 32}
Il 27/05/2014 03:39, arei.gong...@huawei.com ha scritto:
(1) Event assignment: Assigning: "pixels" = "0".
(2) Event cond_true: Condition "y < h", taking true branch
(3) Event cond_false: Condition "x < w", taking false branch
(4) Event loop_end: Reached end of loop
(5) Event divide_by_zero: In expression "(stats[0] + stats[1]) * 100U /
pixels",
division by expression "pixels" which may be zero has undefined behavior.
I'm quite sure that this cannot happen (h and w must be > 0) but it
doesn't hurt.
Sorry for my poor English, do you agree with accept the patch or not, Paolo?
Yes, please include it in v2.
Paolo
