On Di, 2014-05-27 at 15:36 +0200, Paolo Bonzini wrote: > Il 27/05/2014 03:40, arei.gong...@huawei.com ha scritto: > > From: Gonglei <arei.gong...@huawei.com> > > > > Spotted by Coverity: > > > > (1) Event unreachable: This code cannot be reached: "abort();". > > > > 112 abort(); > > > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > > --- > > hw/i2c/pm_smbus.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c > > index fedb5fb..da09eb0 100644 > > --- a/hw/i2c/pm_smbus.c > > +++ b/hw/i2c/pm_smbus.c > > @@ -109,7 +109,6 @@ static void smb_transaction(PMSMBus *s) > > default: > > goto error; > > } > > - abort(); > > This is intentional defensive programming. A "break" from the switch > would be wrong, hence the "abort" here.
Could be replaced with a "g_assert_notreach()" to make that more clear? cheers, Gerd
