> -----Original Message----- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Wednesday, May 28, 2014 1:52 AM > To: Konrad Rzeszutek Wilk > Cc: Chen, Tiejun; anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com; > m...@redhat.com; kelly.zyta...@amd.com; peter.mayd...@linaro.org; > xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; > anth...@codemonkey.ws; Zhang, Yang Z > Subject: Re: [Xen-devel] [v3][PATCH 2/5] xen, gfx passthrough: create intel > isa > bridge > > On Tue, 27 May 2014, Konrad Rzeszutek Wilk wrote: > > On Mon, May 26, 2014 at 05:43:06PM +0800, Tiejun Chen wrote: > > > ISA bridge is needed since Intel gfx drive will probe it instead of > > > Dev31:Fun0 to make graphics device passthrough work easy for VMM, > > > that only need to expose ISA bridge to let driver know the real hardware > underneath. > > > > > > The original patch is from Allen Kay [allen.m....@intel.com] > > > > > > Signed-off-by: Yang Zhang <yang.z.zh...@intel.com> > > > Signed-off-by: Tiejun Chen <tiejun.c...@intel.com> > > > Cc: Allen Kay <allen.m....@intel.com> > > > --- > > > v3: > > > > > > * Fix some typos. > > > * Improve some return paths. > > > > > > v2: > > > > > > * Nothing is changed. > > > > > > hw/xen/xen_pt_graphics.c | 63 > > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 63 insertions(+) > > > > > > diff --git a/hw/xen/xen_pt_graphics.c b/hw/xen/xen_pt_graphics.c > > > index e63bd6f..51b174f 100644 > > > --- a/hw/xen/xen_pt_graphics.c > > > +++ b/hw/xen/xen_pt_graphics.c > > > @@ -230,3 +230,66 @@ out: > > > g_free(bios); > > > return rc; > > > } > > > + > > > +static uint32_t isa_bridge_read_config(PCIDevice *d, uint32_t addr, > > > +int len) { > > > + return pci_default_read_config(d, addr, len); } > > > + > > > +static void isa_bridge_write_config(PCIDevice *d, uint32_t addr, uint32_t > v, > > > + int len) { > > > + pci_default_write_config(d, addr, v, len); > > > + > > > + return; > > > > You don't need the return there. > > > +} > > > + > > > +static void isa_bridge_class_init(ObjectClass *klass, void *data) { > > > + PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > > + > > > + k->config_read = isa_bridge_read_config; > > > + k->config_write = isa_bridge_write_config; > > > + > > > + return; > > > > Ditto > > Aside from these 2 minor changes, the patch looks good to me. >
Already addressed Thanks Tiejun
