> -----Original Message-----
> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> Sent: Wednesday, May 28, 2014 1:48 AM
> To: Chen, Tiejun
> Cc: anthony.per...@citrix.com; stefano.stabell...@eu.citrix.com;
> m...@redhat.com; kelly.zyta...@amd.com; qemu-devel@nongnu.org;
> xen-de...@lists.xensource.com; peter.mayd...@linaro.org;
> anth...@codemonkey.ws; Kay, Allen M; Zhang, Yang Z
> Subject: Re: [v3][PATCH 1/5] xen, gfx passthrough: basic graphics passthrough
> support
>
[snip]
> > + * register VGA resources for the domain with assigned gfx */ int
> > +xen_pt_register_vga_regions(XenHostPCIDevice *dev) {
> > + int i = 0;
> > +
> > + if (!is_vga_passthrough(dev)) {
> > + return -1;
>
> Given that xen_pt_register_vga_regions is called unconditionally, this is not
> an
> error condition, isn't it? It should return 0.
Okay.
>
[snip]
> > + * unregister VGA resources for the domain with assigned gfx */ int
> > +xen_pt_unregister_vga_regions(XenHostPCIDevice *dev) {
> > + int i = 0;
> > +
> > + if (!is_vga_passthrough(dev)) {
> > + return -1;
>
> same here
>
Fixed.
>
[snip]
> > const ram_addr_t default_ram_size =
> (ram_addr_t)DEFAULT_RAM_SIZE *
> > 1024 * 1024;
> > -
>
> Spurious change
>
Removed.
Thanks
Tiejun
