Benoît Canet <benoit.ca...@irqsave.net> writes:
> The Monday 26 May 2014 à 19:37:07 (+0200), Markus Armbruster wrote :
>> Introduced in commit b543c5c. Spotted by Coverity.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> qemu-io.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qemu-io.c b/qemu-io.c
>> index ef3fef6..ffbad25 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -175,6 +175,7 @@ static int open_f(BlockDriverState *bs, int argc, char
>> **argv)
>> } else if (optind == argc) {
>> return openfile(NULL, flags, growable, opts);
>> } else {
>> + QDECREF(opts);
>> return qemuio_command_usage(&open_cmd);
>> }
>> }
>> --
>> 1.9.3
>>
>>
> There is still a potential leak in openfile() in if (qemuio_bs).
I said "plug memory leak in open command", not "plug all memory leaks in
open command" ;)
Back to serious: you're right, and I'll plug that one, too.
